Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42308 )
Change subject: mb/google/volteer: Enable HECI interface
......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Can you add information or use case why this needs to be enabled in commit message?
Okay will do.
https://review.coreboot.org/c/coreboot/+/42308/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42308/3//COMMIT_MSG@11
PS3, Line 11: None
If this is not required to address a bug, why is this change required? Or does switching to CSME Li […]
This change is added for WV/PAVP enablement with CSE Lite. I will add the right bug number for this activity. Thanks for pointing this out. We don't need to include this change to switch to CSE Lite, but there will be no issue by including this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68eb51c6a0af77982c060767993265764a2bc926
Gerrit-Change-Number: 42308
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:45:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment