Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig
......................................................................
Patch Set 2:
(2 comments)
Do you mind to add MAX_CPUS to the Kconfig as on a different patch (CB:45063) we have missed this define for APL and need to fix it now.
https://review.coreboot.org/c/coreboot/+/45078/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/1//COMMIT_MSG@16
PS1, Line 16: I2c
I2C
https://review.coreboot.org/c/coreboot/+/45078/2/src/soc/intel/elkhartlake/K...
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45078/2/src/soc/intel/elkhartlake/K...
PS2, Line 76: default 0x30000
This results in 192 kB while the help text is changed to 128 kB. What is the size that needs to be used here, 192k or 128k?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a44d357d71be706f402a6b2a4f2d4e7c0eeb4a9
Gerrit-Change-Number: 45078
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 10:16:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment