[coreboot-gerrit] Change in coreboot[master]: supermicro/x11-lga1151/gpio: 4/4 Convert field macros to PAD_CFG

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35679 )

Change subject: supermicro/x11-lga1151/gpio: 4/4 Convert field macros to PAD_CFG
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35679/12/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/35679/12/src/mainboard/supermicro/x... 
PS12, Line 16: 	/* GPP_A1 - LAD0 */
I had some discussion about gpio.h comments in general. Since we don't have any schematics for the two boards the comments aren't helpful at all. The standard stuff is always the same per platform so they're not helpful, too.

This multiline format (comment\npadcfg) is barely readable, I'd like to see single lines here without all those newlines.

My suggestion:
- drop the pad comments completely (except the GPIO group comments)
- drop all those newlines, except those after each GPIO group

same applies to x11ssh-tf