[coreboot-gerrit] Change in coreboot[master]: trogdor: mainboard reference all QUPv3 FW drivers

[mturney mturney (Code Review)]

mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )

Change subject: trogdor: mainboard reference all QUPv3 FW drivers
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... 
File src/mainboard/google/trogdor/mainboard.c:

https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... 
PS12, Line 43: 	qup_spi_init(QUPV3_1_SE0, 1010 * KHz); /* H1 SPI */
> These are incorrect, each bus should only be initialized once (and these are already in the bootbloc […]

Done

https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... 
PS12, Line 50: 	uart_init(QUPV3_0_SE3); /* BT UART */
> For those which we're not going to use in firmware, we don't have to do the whole controller init. […]

Done