Attention is currently required from: Felix Singer, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email )
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS6:
I'm pretty sure it works as is, but I'll recheck
It did work before due the the PATH environment variable being set to /python3:$PATH. I figured out the issue I was having before adding an unprivileged user and switched to that, so now it's handled pretty much the same as coreboot-jenkins-node. `make -C util/docker doc.coreboot.org` and `make -C util/docker docker-build-docs` do work properly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80311?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Gerrit-Change-Number: 80311
Gerrit-PatchSet: 8
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Mon, 18 Mar 2024 04:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment