Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42460 )
Change subject: treewide: Configure PCI Bus Master based on Kconfig option
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42460/16/src/drivers/intel/i210/i21...
File src/drivers/intel/i210/i210.c:
https://review.coreboot.org/c/coreboot/+/42460/16/src/drivers/intel/i210/i21...
PS16, Line 212: pci_dev_request_bus_master(dev);
I'm not sure if this is equivalent. […]
Writing `dev->command` to the hardware is the next step anyway. And it gets
or'ed with the hardware value so it really shouldn't make any difference.
Using pci_dev_request_bus_master() (in its current implementation) adds
a RMW cycle, but that seems better than adding yet another `if`, doesn't it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25565315a5ddf8d53097ac4cb4884ecebcc9c0a9
Gerrit-Change-Number: 42460
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 14:37:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment