Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40379 )
Change subject: soc/intel/common/block/systemagent: Add choice option for PCIEX_LENGTH
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40379/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/40379/1/src/soc/intel/common/block/...
PS1, Line 25: This is to provide new kconfig option
Not needed?
Done
https://review.coreboot.org/c/coreboot/+/40379/1/src/soc/intel/common/block/...
PS1, Line 26: select PCI Express Base Address Length.
It’d be great, if you described, what length should be used for what case.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb61e9a0263c058726cc07442af1985a96bf37c2
Gerrit-Change-Number: 40379
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Apr 2020 12:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment