Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 13: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/mmc.h:
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block... PS13, Line 21: /* : * Following should be defined in soc/iomap.h : * PRERAM_MMC_BASE_ADDRESS - Provide an address to setup emmc controller's : PCI BAR. : */ nit: Can you please move this under SOC_INTEL_COMMON_EARLY_MMC_WAKE (i.e. line 77)
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/13/src/soc/intel/common/block... PS13, Line 75: (void *) nit: Why not pass uintptr_t all the way to mmc_write_dll_reg() and let it cast to (void *)(bar + reg) ?