[coreboot-gerrit] Change in ...coreboot[master]: drivers/ipmi: Add chip ops

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33255 )

Change subject: drivers/ipmi: Add chip ops
......................................................................

Patch Set 8:

(2 comments)

didn't really review ipmi_kcs_ops.c yet

https://review.coreboot.org/#/c/33255/8/Documentation/drivers/ipmi_kcs.md 
File Documentation/drivers/ipmi_kcs.md:

https://review.coreboot.org/#/c/33255/8/Documentation/drivers/ipmi_kcs.md@14 
PS8, Line 14:     
remove whitespace

https://review.coreboot.org/#/c/33255/8/src/drivers/ipmi/ipmi_kcs.h 
File src/drivers/ipmi/ipmi_kcs.h:

https://review.coreboot.org/#/c/33255/8/src/drivers/ipmi/ipmi_kcs.h@51 
PS8, Line 51: adtl
this abbreviation for additional isn't very obvious; i'd either not abbreviate it (preferred option) or at least name it addtl (just the vowel removed and not the rest deduplicated)