Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37497 )
Change subject: fmap: Make FMAP_CACHE mandatory if it is configured in
......................................................................
Patch Set 1:
Hmm. I don't know about FMAP_CACHE so I really can't comment on this
right now. I assume its documented somewhere?
Not much. Original CL is CB:36657.
Basically, I'm just asking if your platform can spare the extra 2K I'm carving out here and if I can rely on that staying available from the bootblock through to romstage. If so, you probably want it because it may safe a few ms of boot time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d47772ab3abfa7e3a66815c3739d0af071abc2
Gerrit-Change-Number: 37497
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 06 Dec 2019 01:56:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment