HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 )
Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/apollolake/Kc... PS3, Line 84: SOC_INTEL_COMMON_BLOCK_SA
This already defines MMCONF_BASE_ADDRESS
Done
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/cannonlake/Kc... PS3, Line 98: SOC_INTEL_COMMON_BLOCK_SA
This already defines MMCONF_BASE_ADDRESS
Done
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/Kconfig:
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/denverton_ns/... PS3, Line 45: config MMCONF_BASE_ADDRESS : hex : default 0xe0000000
See this.
Done
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/skylake/Kconf... File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/skylake/Kconf... PS3, Line 63: SOC_INTEL_COMMON_BLOCK_SA
This already defines MMCONF_BASE_ADDRESS
Done