Attention is currently required from: Tim Wawrzynczak, Amanda Hwang, Patrick Rudolph, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54950 )
Change subject: soc/intel/alderlake: Add new memory parts for ADL boards
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/spd/lp4x_spd_manifest.generated.txt:
https://review.coreboot.org/c/coreboot/+/54950/comment/428da427_296c0295
PS2, Line 6: MT53E1G32D2NP-046 WT:B,lp4x-spd-1.hex
Taking a look now.
Looks like the part attributes added for `MT53E1G32D2NP-046 WT:B` used wrong # of ranks. Once that is fixed, the SPD allocation for these two parts should be separate. Thanks for catching this Eric! 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e76a887f81d432adbcfc2f8956b44f4343db5c2
Gerrit-Change-Number: 54950
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 May 2021 16:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment