build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25514 )
Change subject: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c File src/soc/intel/apollolake/early_mmc.c:
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c... PS5, Line 25: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_104, UP_20K, DEEP, NF1),/*EMMC_DNX_PWR_EN_B*/ line over 80 characters
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c... PS5, Line 37: PAD_CFG_NF_IOSSTATE(GPIO_209, DN_20K, DEEP, NF1, HIZCRx0)/*EMMC0_STROBE*/ line over 80 characters
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c... PS5, Line 61: __func__); code indent should use tabs where possible
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c... PS5, Line 61: __func__); please, no spaces at the start of a line
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@... PS5, Line 207: printk(BIOS_DEBUG, "Early mmc initilization failed \n"); 'initilization' may be misspelled - perhaps 'initialization'?
https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@... PS5, Line 207: printk(BIOS_DEBUG, "Early mmc initilization failed \n"); unnecessary whitespace before a quoted newline