Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd:
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... PS3, Line 5: SI_GBE@0x81000 0x2000
Yes, this is actually essential for CFL-S/H CML-S/H RVPs. With this region available, you can use enable the config file to specify GBE bin location and ifdtool will stitch it into image.
Please do some research on the topic. Defining this region in fmap is not essential at all and for what it's worth the fmd file is not even used when not selecting chromeos. Moreover, GBE is *disabled* on the board you're adding! ifdtool does *not* use fmap to insert the GBE configuration binary.