Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56121 )
Change subject: arch/x86: smbios write 7 table using deterministic cache functions ......................................................................
Patch Set 10:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/56121/comment/74184b9a_17019794 PS10, Line 813: continue;
Is it an infinite loop here when fill_cpu_cache_info() return false (will happen if cpu_get_cache_in […]
Thanks for your reply. I guessed that if fill_cpu_cache_info() function return 0 then only it might cause the infinite loop. But for that to happen we might need one of below condition is set
1. cpu_get_cache_info_leaf() return 0 2, info is NULL
For #1, we already have same check at line https://review.coreboot.org/c/coreboot/+/56121/10/src/arch/x86/smbios.c#803 where we are checking if cpu_check_deterministic_cache_cpuid_supported() doesn't support deterministic cache hence we could "safely" assume that, if the said platform doesn't support this feature then it would have returned from there isn't it? rather enter into this while(1) and then say it doesn't support this CPUID?
For #2, do we suspect this ?