Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte...
File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte...
PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
To do this, please remove line 28 from this Kconfig file and add SOC_INTEL_CSE_LITE_SKU to each vari […]
Nick, With current implementation, CSE SKU info is checked to execute CSE Lite specific code for CSE Lite SKU only, so platforms with Consumer SKU won't have an issue to boot and run with Consumer SKU. But I think you are right and it makes more sense to turn this only for the boards that use CSE Lite blob.
Would you let me know the list of board name that uses es2 blob? I see halvor, malefor, terrador, trondo, volteer and voxel if I exclude ripto, volteer2 and delbin.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42070
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b
Gerrit-Change-Number: 42070
Gerrit-PatchSet: 15
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sowmya V
v.sowmya@intel.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 19:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment