EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39352 )
Change subject: lib/spd_bin: Extend LPDDR4 SPD information ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG@7 PS2, Line 7: spd
SPD
Done
https://review.coreboot.org/c/coreboot/+/39352/2//COMMIT_MSG@9 PS2, Line 9: spd
SPD
Done
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@81 PS2, Line 81: 96, 12, 24, 72 };
Actually I want to cut this into two equal lines. Because it too long and hard to count it.. […]
Done
https://review.coreboot.org/c/coreboot/+/39352/2/src/lib/spd_bin.c@180 PS2, Line 180: printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
I am okay with this. Will do later.
Done