Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44241 )
Change subject: cpu/intel/model_6xx: Unify all Slot 1 CPUs ......................................................................
Patch Set 4:
(1 comment)
It might also be worth stating in the commit message that it assumes the only users of the CPU's will be slot_1 (which supports all of these?) and that further distinction should not be needed.
https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c:
https://review.coreboot.org/c/coreboot/+/44241/4/src/cpu/intel/model_6xx/mod... PS4, Line 26: if ((dev->device & 0x0ff0) == 0x0680 || (dev->device & 0x0ff0) == 0x06b0) { : char processor_name[49]; : : fill_processor_name(processor_name); : printk(BIOS_INFO, "CPU: %s.\n", processor_name); : }
I did it this way to preserve the behavior of the original code with this commit. I can ofc change this in a follow-up. Sounds good?
sure!