Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43659 )
Change subject: vc/amd/fsp/picasso: update UPD header ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/43659/2/src/vendorcode/amd/fsp/pica... PS2, Line 20: /** Offset 0x00C0**/ uint32_t ddi_descriptor[FSPS_UPD_DDI_DESCRIPTOR_COUNT];
Where is the corresponding private CL for changing this ABI?
https://chrome-internal-review.googlesource.com/c/chromeos/third_party/amd-f... should i add that to the commit message?