Attention is currently required from: ritul guru, Eric Lai, Anand Vaikar, Fred Reitberger, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74057 )
Change subject: configs/config.amd_mayan:Add the defconfig file for Mayan board
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74057/comment/1cb8433d_7d11d4e3
PS2, Line 7: configs/config.amd_mayan:Add
Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/74057/comment/a31f2fcd_4d2cc7a9
PS2, Line 7: the
The article could be omitted in the summary.
https://review.coreboot.org/c/coreboot/+/74057/comment/332af7cc_6e35c695
PS2, Line 8:
What is the difference to the default config created for that board?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibddd49a6611e95c2c986c4de1d7052e70622ad32
Gerrit-Change-Number: 74057
Gerrit-PatchSet: 2
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 05 Apr 2023 11:25:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment