Jason V Le has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45216 )
Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Disable TBT_PCIe3 for TGL-Y RVP
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45216/1/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45216/1/src/mainboard/intel/tglrvp/...
PS1, Line 168:
any reason xdci is enabled?
Not sure. For debugging purpose?
https://review.coreboot.org/c/coreboot/+/45216/1/src/mainboard/intel/tglrvp/...
PS1, Line 170:
why do we disable DMA1 on UP4?
It was temporarily turned off earlier to get around with coreboot reboot issue. I can enable it now. Will update in the second patchset
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45216
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba873832931c17eed5908127dbb2e44b41f46bf
Gerrit-Change-Number: 45216
Gerrit-PatchSet: 1
Gerrit-Owner: Jason V Le
jason.v.le@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 16 Sep 2020 00:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-MessageType: comment