Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47991 )
Change subject: soc/intel/common/fast_spi: Add support for configuring MTRRs
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47991/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/fast_spi.h:
https://review.coreboot.org/c/coreboot/+/47991/4/src/soc/intel/common/block/...
PS4, Line 86: /*
: * Postcar cache for extended BIOS region
: */
Single line comment: /* ... */ […]
I tried to keep the comment consistent with the other single line comments in this file, I can change it to single line, let me know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9711f110a35a167efe3a4c912cf46c63c0812779
Gerrit-Change-Number: 47991
Gerrit-PatchSet: 5
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Nov 2020 10:58:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment