Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )
Change subject: device/xhci: Add an xhci driver to enumerate capabilities ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41899/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41899/1//COMMIT_MSG@10 PS1, Line 10: generating the ACPI device nodes.
I always wonder, if coreboot has code to generate the ACPI code, why the OS/payload can’t do it itse […]
Coreboot has additional information it needs to pass along for each device node: https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/zork/v...
So we need to basic structure generated to add the additional data.
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/Makefile.inc File src/device/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/Makefile.inc@66 PS1, Line 66: y Should I add a Kconfig for this?
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c File src/device/xhci.c:
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c@42 PS1, Line 42: ext_caps_offset = read16(bar + XHCI_HCCPARAMS1_XECP);
Should a warning be printed, if that reads back 0?
I guess I can make it print an error and return CB_ERR.
https://review.coreboot.org/c/coreboot/+/41899/1/src/device/xhci.c@68 PS1, Line 68:
Should some debug prints be added to print the capabilities for debugging? The Linux driver allows t […]
I can add an xhci_print_supported_protocol that the callbacks can call if they want to debug.