[coreboot-gerrit] [S] Change in coreboot[main]: src/lib: Add Kconfig variable for fw_config default value

[Paul Menzel (Code Review)]

Attention is currently required from: Bora Guvendik, Cliff Huang, Julius Werner, Wonkyu Kim.

Paul Menzel has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )

Change subject: src/lib: Add Kconfig variable for fw_config default value
......................................................................

Patch Set 3:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83153/comment/2c3e0d22_e01662da?usp... :
PS3, Line 7: src/lib
Just `lib/`?

https://review.coreboot.org/c/coreboot/+/83153/comment/452b5516_ce257f9d?usp... :
PS3, Line 9: is default to
defaults to

https://review.coreboot.org/c/coreboot/+/83153/comment/6e0facf4_aaa9edd3?usp... :
PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to
Please start by describing the problem, you are trying to solve.

https://review.coreboot.org/c/coreboot/+/83153/comment/89fc2ac9_90a4cbae?usp... :
PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to
           : UNDEFINED_FW_CONFIG and won't be used when retrieving fw_config
           : value. Set this with different value in config.<board> file, and
           : it will be used when fw_config is not able to read via Chrome EC,
           : CBFS or VPD.
Please try to use 72 characters per line.

File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/83153/comment/8434ca6e_244514f8?usp... :
PS3, Line 550: when not able to retrieve
This reads strangely. Not able to retrieve *what*?