Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )
Change subject: nb/via/vx900: Assert framebuffer size is within limits
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34355/1/src/northbridge/via/vx900/m...
File src/northbridge/via/vx900/memmap.c:
https://review.coreboot.org/c/coreboot/+/34355/1/src/northbridge/via/vx900/m...
PS1, Line 82: int
If size_mb is somehow zero, then fb_pow will underflow in the subtraction to 255. […]
I'd just catch the zero separately, since it's rather significant (how do you end up with size_mb = 0 other than with some serious issue in the previous code?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3962e5cdc094c8da22d8dbadf16637e02fa98689
Gerrit-Change-Number: 34355
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jul 2019 00:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment