Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: A common API for loading the blob file ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... File src/soc/mediatek/common/mtlib.c:
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... PS14, Line 25: memcpy((void *)addr, blob_data, blob_bytes);
One question. […]
Hi Hung-te, do you mean feed the addr to cbfs_boot_load_file() ?
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt... PS14, Line 27: /* Memory barrier to ensure that all firmware code is loaded : * before we release the reset pin. : */
given this is a generic function now maybe: […]
Let me clarify how those blobs are loaded. 1. For 2 dpm binaries and SSPM binary, AP copies the binary to the target SRAM(addr). 2. For SPM binary, AP can't touch the SPM's SRAM. We can only use SPM's DMA hardware to move the binary from DRAM(non-cacheable buffer) to its SRAM.