Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31225 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
I think that until we find at least one G505S user who needs Intel WiFi we could safely default it to "n". Why default this to "y" if we don't know anyone who needs it?
My g505s now has Intel WiFi. Previously it had none.
This means my -1 is staying. I can see no valid reason to make the default less compatible.
My point is that the default settings should suit the needs of majority, especially considering that in this particular case it's likely that minority doesn't exist. Meanwhile I've already found myself a couple of times in a situation where I had to disable DRIVERS_INTEL_WIFI in order to save a few kilobytes to make enough remaining room for the last floppy image of my interest
You are in the minority with your need to tune up last kilobytes from ramstage. You need to adopt, probably should be building from local branch anyways. Default build is clearly not for you.
Definitely agree with this.