Attention is currently required from: Angel Pons, Felix Held. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 32:
(5 comments)
File src/mainboard/apple/macbookair5_2/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/32604/comment/dbfb7bf9_d4d43404 PS23, Line 2: : cbfs-files-y += spd.bin : spd.bin-file := spd.bin : spd.bin-type := spd
I think you can use GENERIC_SPD_BIN. […]
Done
File src/mainboard/apple/macbookair5_2/cmos.layout:
PS25:
Same as on MBP 10,1 patch
Done
File src/mainboard/apple/macbookair5_2/romstage.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/d3ba1867_26e787c3 PS1, Line 78: void *spd_file; : size_t spd_file_len = 0; : spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD, : &spd_file_len); : if (spd_file && spd_file_len >= 512) { : memcpy(&spd[0], spd_file, 128); : memcpy(&spd[2], spd_file + 256, 128); : }
So, if I understand properly, this board has two memory "modules" (soldered on the board), and you u […]
Done
File src/mainboard/apple/macbookair5_2/romstage.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/ea76456f_116507fb PS22, Line 67: void mainboard_get_spd(spd_raw_data *spd, bool id_only)
have a look at ramcfg[0.. […]
Done
File src/mainboard/apple/macbookair5_2/romstage.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/cc1b98e9_3522c968 PS23, Line 73: memcpy(&spd[0], spd_file, 128);
Why is only half of the spd file used? Only the 1st and 3rd quarters are used.
Done