Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30934 )
Change subject: qualcomm/qcs405: enable SPI bus 4 for TPM ......................................................................
Patch Set 7: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/30934/7/src/mainboard/google/mistral/verstag... File src/mainboard/google/mistral/verstage.c:
https://review.coreboot.org/#/c/30934/7/src/mainboard/google/mistral/verstag... PS7, Line 4: 2016 Google Inc. Nit: If significant changes were made, you might want to update the copyright.
https://review.coreboot.org/#/c/30934/7/src/soc/qualcomm/qcs405/include/soc/... File src/soc/qualcomm/qcs405/include/soc/spi.h:
https://review.coreboot.org/#/c/30934/7/src/soc/qualcomm/qcs405/include/soc/... PS7, Line 39: (void *) Unrelated to this change, but I think these should be bare numbers to avoid void pointer math.
https://review.coreboot.org/#/c/30934/7/src/soc/qualcomm/qcs405/spi.c File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/30934/7/src/soc/qualcomm/qcs405/spi.c@253 PS7, Line 253: #if 0 Nit: I know it's just moving the function, but maybe remove the dead code or comment why it's here? Since it is a move, i'll leave it up to you.