Patch set 7:Code-Review +2
3 comments:
File src/mainboard/google/mistral/verstage.c:
Patch Set #7, Line 4: 2016 Google Inc.
Nit: If significant changes were made, you might want to update the copyright.
File src/soc/qualcomm/qcs405/include/soc/spi.h:
Patch Set #7, Line 39: (void *)
Unrelated to this change, but I think these should be bare numbers to avoid void pointer math.
File src/soc/qualcomm/qcs405/spi.c:
Patch Set #7, Line 253: #if 0
Nit: I know it's just moving the function, but maybe remove the dead code or comment why it's here?
Since it is a move, i'll leave it up to you.
To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.