Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41154 )
Change subject: amdfwtool: Unpack struct `_bios_directory_entry`
......................................................................
Patch Set 1: Code-Review-1
This might just break the tool. Also I wonder why those accesses aren't aligned; from counting the bits they should be aligned
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I375ffec589cca8fe9d07dbe908c79348e863aa13
Gerrit-Change-Number: 41154
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 May 2020 22:32:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment