Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 2: n Is this correct?
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 10: select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_BOARDID This should be under Chrome EC config
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 28: default "TGLRVP" if BOARD_INTEL_TGLRVP_UP3 If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 36: default "Intel_tglrvp" if BOARD_INTEL_TGLRVP_UP If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 40: default "Tglrvp" if BOARD_INTEL_TGLRVP_UP3 If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 72: select EC_GOOGLE_CHROMEEC_ESPI select EC_GOOGLE_CHROMEEC_BOARDID need to be here
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 74: select GBB_FLAG_FORCE_DEV_SWITCH_ON : select GBB_FLAG_FORCE_DEV_BOOT_USB Is it only required Chrome EC case?
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 4: "-> Tglrvp" "Tigerlake UP3 RVP"