Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29324 )
Change subject: soc/intel/cannonlake: Add additional UPD ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig@266 PS3, Line 266: bool "Use Clean Memory"
Let FSP clean memory
Done
https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig@268 PS3, Line 268: Ask MRC to clear memory content.
Elaborate a little? Is clean and clear the same?
This is the description of the Intel documentation. IDK
https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/romstage/fs... PS3, Line 59: if (IS_ENABLED(CONFIG_USE_CANNONLAKE_CLEAN_MEMORY)) : m_cfg->CleanMemory = 1; : else : m_cfg->CleanMemory = 0;
Use ternary operator? […]
Nope. Harder to read and not better code