[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Add GLK usb2eye configuration override

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31060 )

Change subject: soc/intel/apollolake: Add GLK usb2eye configuration override
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@554 
PS2, Line 554: if (!cfg->usb2eye[port].Usb20OverrideEn)
             : 			continue;
Why is this check required? In case the values are not set, FSP UPDs would be set to 0 and that should be fine.

https://review.coreboot.org/#/c/31060/2/src/soc/intel/apollolake/chip.c@567 
PS2, Line 567: 
One blank line should be sufficient.