Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: Use binaries from Windows installer directly ......................................................................
Patch Set 13: Code-Review+1
(5 comments)
Patch Set 13:
Patch Set 12:
I'd suggest adding the xz code in a separate commit, so that the changes are easier to review.
I'm curious to see if that helps, as the code was very separate before already. But here you go. :-)
It does help! Large changes make Gerrit unbearably sluggish :-P
https://review.coreboot.org/c/em100/+/36943/13/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/36943/13/em100.c@656 PS13, Line 656: static int list_chips_entry(char *name __unused, TFILE *file, void *data __unused, int ok __unused) Sanity check: the return value is always the same. Is this intended? If it is, maybe move the printf() call into the if block instead?
https://review.coreboot.org/c/em100/+/36943/13/em100.c@693 PS13, Line 693: dcfg Sanity check: Is it needed to call `tar_close(dcfg)` before returning?
https://review.coreboot.org/c/em100/+/36943/13/em100.c@989 PS13, Line 989: const Why is this const if its value gets modified by `get_chip_type()`?
https://review.coreboot.org/c/em100/+/36943/13/tar.c File tar.c:
https://review.coreboot.org/c/em100/+/36943/13/tar.c@87 PS13, Line 87: if(!ok) missing space
https://review.coreboot.org/c/em100/+/36943/13/tar.c@121 PS13, Line 121: if(!ok) missing space