Patch Set 13:

Patch Set 12:

I'd suggest adding the xz code in a separate commit, so that the changes are easier to review.

I'm curious to see if that helps, as the code was very separate before already. But here you go. :-)

It does help! Large changes make Gerrit unbearably sluggish :-P

Patch set 13:Code-Review +1

View Change

5 comments:

• File em100.c:

  • Patch Set #13, Line 656: static int list_chips_entry(char *name __unused, TFILE *file, void *data __unused, int ok __unused)

    Sanity check: the return value is always the same. Is this intended? If it is, maybe move the printf() call into the if block instead?

  • Patch Set #13, Line 693: dcfg

    Sanity check: Is it needed to call `tar_close(dcfg)` before returning?

  • Patch Set #13, Line 989: const

    Why is this const if its value gets modified by `get_chip_type()`?

• File tar.c:

  • Patch Set #13, Line 87: if(!ok)

    missing space

  • Patch Set #13, Line 121: if(!ok)

    missing space

To view, visit change 36943. To unsubscribe, or for help writing mail filters, visit settings.