Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG@12 PS18, Line 12: Verified sending HECI global reset message on CML RVP & Hatch board
Plans to verify on ICL/SKL.
Done
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... PS18, Line 572: int send_heci_global_reset_req_message(uint8_t rst_type)
The function is named to align with HECI command.
Done
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... PS18, Line 114: u8
This is named as per HECI command.
Done