Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37515 )
Change subject: drivers/intel/fsp2_0: Add logo support
......................................................................
Patch Set 2: Code-Review+1
Patch Set 2:
(1 comment)
Patch Set 1:
Since this seems to be one of those "move responsibility into FSP" things: what does this provide over our coreboot-side splash screen feature?
Basically it adds BMP support, which is not in the current coreboot implementation. This allows us to use one logo as splash screen for coreboot and a logo published in the BGRT table. The EDK payloads also use the BMP format.
So this is not a replacement, it is just an additional feature that can be used when needed.
Out of curiosity, which platform do you plan to use this on? With libgfxinit and tianocore, coreboot can be made to show a .bmp bootsplash already.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaffd2be567861371bbe908c1ef9d7dde483a945
Gerrit-Change-Number: 37515
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Dec 2019 13:59:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment