[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Use SPI settings from EFS

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )

Change subject: soc/amd/common: Use SPI settings from EFS
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp... 
File src/soc/amd/common/block/spi/fch_spi.c:

https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp... 
PS4, Line 92: 			   *spi_speed, *spi_speed);
I might not agree about using same max spi_speed for all fast,norm,alt and tpm here. But I don't have BOM or necessary datasheets to give any more accurate comments that I already have placed in CB:43306.

https://review.coreboot.org/c/coreboot/+/43303/4/src/soc/amd/common/block/sp... 
PS4, Line 101: fch_spi_config_modes
> Can we just delete all of this now?

If you do, please verify if you need to configure different norm and fast spi_speed parameters based on the BOM. AFAIR one cannot parse devicetree parameters into commandline arguments to be passed for amdfwtool.