Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42436 )
Change subject: mb/google/volteer: Override power limits with SKU-specific limits ......................................................................
Patch Set 2:
(3 comments)
ya, this
https://review.coreboot.org/c/coreboot/+/42436/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42436/1/src/mainboard/google/voltee... PS1, Line 28: override_power_limits
Also with the new patch set, that concern is no longer there.
cool, ya the new patchset does provide better control over the values.
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/chi... PS2, Line 25: #define POWER_LIMITS_4_CORE 0 : #define POWER_LIMITS_2_CORE 1 we may want to use more descriptive naming here, specially since this is exposed in the device tree. there'll be a tier of values for TGL-U and a tier for TGL-Y. 2-core vs. 4-core is likely going to be ambiguous.
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/sys... File src/soc/intel/tigerlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/sys... PS2, Line 80: switch (sa_pci_id) { we'll need to include PCI_DEVICE_ID_INTEL_TGL_ID_Y at some point.