Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32083 )
Change subject: libpayload: Fix potential NULL pointer dereference ......................................................................
Patch Set 10:
(11 comments)
Patch Set 8: Code-Review-1
(4 comments)
Paul and HAOUAS,
You findings have been implemenented. Please take a look.
Regards, Francois
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG@7 PS8, Line 7: payload/libpayload: This is a fix for potential NULL pointer dereferences
Please use: […]
Done
https://review.coreboot.org/#/c/32083/8//COMMIT_MSG@10 PS8, Line 10:
Just add a tag: […]
Done
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... PS8, Line 659: memory
Also *DMA memory* here?
Done
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... PS8, Line 659: memory
Also *DMA memory* here?
Done
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ehci... PS8, Line 842:
related ?
Done
https://review.coreboot.org/#/c/32083/9/payloads/libpayload/drivers/usb/ehci... File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/#/c/32083/9/payloads/libpayload/drivers/usb/ehci... PS9, Line 841: periodic_list[i] = virt_to_phys(EHCI_INST(controller)->dummy_qh) | PS_TYPE_QH;
line over 80 characters
Ack
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... PS8, Line 577: fatal("Not enough DMA memory for OHCI addition TD in bulk transfer.\n");
line over 80 characters
Ack
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... PS8, Line 703: memory
DMA memory
Done
https://review.coreboot.org/#/c/32083/8/payloads/libpayload/drivers/usb/ohci... PS8, Line 703: fatal("Not enough memory to add transfer descriptor.\n");
line over 80 characters
Ack
https://review.coreboot.org/#/c/32083/9/payloads/libpayload/drivers/usb/ohci... File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/9/payloads/libpayload/drivers/usb/ohci... PS9, Line 577: fatal("Not enough DMA memory for OHCI addition TD in bulk transfer.\n");
line over 80 characters
Ack
https://review.coreboot.org/#/c/32083/9/payloads/libpayload/drivers/usb/ohci... PS9, Line 703: fatal("Not enough DMA memory to add transfer descriptor.\n");
line over 80 characters
Ack