Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39805 )
Change subject: acpi: Bump FADT to revision 6 ......................................................................
Patch Set 4:
(11 comments)
working on Lynxpoint-LP now. Just need to either add the sleep control/status widths where missing, or drop from the common FADT implementation to be consistent
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/emulation/qem... PS4, Line 42: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/t400/f... File src/mainboard/lenovo/t400/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/t400/f... PS4, Line 22: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/x200/f... File src/mainboard/lenovo/x200/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/lenovo/x200/f... PS4, Line 22: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/roda/rk9/fadt... File src/mainboard/roda/rk9/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/mainboard/roda/rk9/fadt... PS4, Line 22: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/picasso/acpi.c@... PS4, Line 70: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/stoneyridge/acp... File src/soc/amd/stoneyridge/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/amd/stoneyridge/acp... PS4, Line 72: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/baytrail/acpi... File src/soc/intel/baytrail/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/baytrail/acpi... PS4, Line 138: acpi_fill_in_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/braswell/acpi... File src/soc/intel/braswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/braswell/acpi... PS4, Line 142: acpi_fill_in_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/broadwell/acp... File src/soc/intel/broadwell/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/broadwell/acp... PS4, Line 193: acpi_fill_in_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/quark/acpi.c File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/soc/intel/quark/acpi.c@... PS4, Line 31: acpi_fill_in_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;
https://review.coreboot.org/c/coreboot/+/39805/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/fadt.c:
https://review.coreboot.org/c/coreboot/+/39805/4/src/southbridge/intel/i8237... PS4, Line 30: acpi_create_fadt missing: fadt->sleep_control_reg.bit_width = 8; fadt->sleep_status_reg.bit_width = 8;