Attention is currently required from: ChiaLing, Paul Menzel, Ryan Lin, Subrata Banik, Sumeet R Pawnikar, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75680?usp=email )
Change subject: mb/google/dedede: Support variant specific power limits
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Build is failing again.
File src/mainboard/google/dedede/variants/baseboard/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75680/comment/4a5d6e2f_f1b080a5 :
PS6, Line 76: soc_config->tdp_pl4 = 0;
I don't think you need to zero this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75680?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583c930379233322c41027805369f81d02000ee7
Gerrit-Change-Number: 75680
Gerrit-PatchSet: 6
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 01:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment