6 Jan
2020
6 Jan
'20
1:17 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38036 )
Change subject: nb/intel/sandybridge: Add a bunch of MCHBAR defines ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38036/7/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/38036/7/src/northbridge/intel/sandy... PS7, Line 45: 0x4220 + 0x400 * X + 4 * Y replace with new macro? same for the lines below
https://review.coreboot.org/c/coreboot/+/38036/7/src/northbridge/intel/sandy... PS7, Line 67: 4284 this also has a better name now; maybe IOSAV_SEQ_CTL_RUN(x) ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/38036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e5fe56eaa90842dbbdd1bfbbcb7709237b4c486
Gerrit-Change-Number: 38036
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jan 2020 16:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment