Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )
Change subject: console/vtxprintf.c: Use same indents for switch/case
......................................................................
Patch Set 2:
(1 comment)
File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/49204/comment/a5c7ef6c_ae4050cd
PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;
Yeah, I don't consider this an improvement, but I think our coding style doesn't capture this syntax […]
That's the problem, right? If we have reasons to +2 either direction,
we risk to walk in circles :D
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728
Gerrit-Change-Number: 49204
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 07 Jan 2021 20:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment