Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31943 )
Change subject: vboot: deprecate physical dev switch ......................................................................
Patch Set 6:
(4 comments)
Patch Set 5:
Also that jenkins failure will get fixed with a rebase to master.
Right, thanks!
https://review.coreboot.org/#/c/31943/5/src/mainboard/google/beltino/chromeo... File src/mainboard/google/beltino/chromeos.c:
https://review.coreboot.org/#/c/31943/5/src/mainboard/google/beltino/chromeo... PS5, Line 31: #ifndef __PRE_RAM__
This changed in master, might require manual rebase.
Thanks for the reminder!
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... File src/mainboard/samsung/lumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... PS3, Line 61: 3
Uhh... fix GPIO_COUNT and remove the gap please. […]
Done
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/lumpy/chromeos... PS3, Line 119: static const struct cros_gpio cros_gpios[] = {
Do we wanna get rid of the CROS_GPIO_DEV_AL/AH macros as well while we're at it? And maybe remove or […]
Let's deal with the ACPI stuff separately. I wrote a bunch about it here: https://bugs.chromium.org/p/chromium/issues/detail?id=942901#c13
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/stumpy/chromeo... File src/mainboard/samsung/stumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/3/src/mainboard/samsung/stumpy/chromeo... PS3, Line 58: gpios->gpios[3].port = 100;
Same here.
Done