Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38187 )
Change subject: console/post: Split parts to arch/ ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38187/4/src/console/post.c File src/console/post.c:
https://review.coreboot.org/c/coreboot/+/38187/4/src/console/post.c@36 PS4, Line 36: mainboard_post(value);
I wonder: shouldn't this be inside the if(!CONFIG(NO_POST)) ?
It's used on two boards (see src/mainboard/google/drallion/ec.c and src/mainboard/google/sarien/ec.c) which send the post code to the EC. I guess "no post" is supposed to mean "no post whatsoever" in which case you're right. I'd do it as a separate commit though since that's a change in semantics: https://review.coreboot.org/c/coreboot/+/38408