View Change
1 comment:
File src/console/post.c:
Patch Set #4, Line 36: mainboard_post(value);
I wonder: shouldn't this be inside the if(!CONFIG(NO_POST)) ?
It's used on two boards (see src/mainboard/google/drallion/ec.c and src/mainboard/google/sarien/ec.c) which send the post code to the EC. I guess "no post" is supposed to mean "no post whatsoever" in which case you're right. I'd do it as a separate commit though since that's a change in semantics: https://review.coreboot.org/c/coreboot/+/38408
To view, visit change 38187. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I010af3f645c0be38dd856657874c36103aebbdc2
Gerrit-Change-Number: 38187
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 14 Jan 2020 18:08:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment