Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
LGTM
https://review.coreboot.org/c/coreboot/+/42242/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42242/3//COMMIT_MSG@9 PS3, Line 9: Implement setting processor information to BMC.
It is defined in document YosemiteV3_BMC_Feature_Spec_v1.7 on dropbox.
Done
https://review.coreboot.org/c/coreboot/+/42242/3/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/42242/3/src/drivers/ocp/ipmi/ipmi_o... PS3, Line 65: memcpy(&req1.data.manufacturer_id, &mfid, 3);
If CONFIG_MANU_ID is not defined, the default value 0x0 may be used and other information may still […]
Done
https://review.coreboot.org/c/coreboot/+/42242/3/src/drivers/ocp/ipmi/ipmi_o... PS3, Line 125: /* TBD */
There should be a CPU identification table such as in chapter 2. […]
Done