Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35757 )
Change subject: sb/intel/ibexpeak: Fix enabling HPET
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG@9
PS2, Line 9: RCBA_HPTC needs to be read back to properly work.
: This fixes SeaBIOS endlessly waiting for input instead of booting the
: default entry.
Ack
Done
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp...
PS2, Line 397: RCBA32(HPTC); /* Read back for it to work */
It applies to everything that uses HPET.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22b8b34924f2add2185ec46470c1559bf2fb6d58
Gerrit-Change-Number: 35757
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Oct 2019 08:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment